Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types: VictorySelectionContainer #1530

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Add types: VictorySelectionContainer #1530

merged 3 commits into from
Apr 29, 2020

Conversation

kale-stew
Copy link
Contributor

This PR

  • enhances the shared VictoryContainerProps
  • adds types for the VictorySelectionContainer
  • adds a tsx demo to test the VictorySelectionContainer types

@wsparsons wsparsons mentioned this pull request Apr 24, 2020
Closed
24 tasks
boygirl
boygirl approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

maddles
maddles approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@maddles maddles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@kale-stew kale-stew force-pushed the types/victory-selection-container branch from 531bc16 to cdc0315 Compare April 29, 2020 18:24
@wsparsons wsparsons merged commit eeea285 into master Apr 29, 2020
@boygirl boygirl deleted the types/victory-selection-container branch June 23, 2020 18:58
@jesper-stighem-pini jesper-stighem-pini mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddles maddles maddles approved these changes

@boygirl boygirl boygirl approved these changes

@wsparsons wsparsons Awaiting requested review from wsparsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kale-stew @maddles @boygirl @wsparsons