Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit typescript props for VictoryArea. Add origin, change to multila… #1534

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Audit typescript props for VictoryArea. Add origin, change to multila… #1534

merged 1 commit into from
Apr 27, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented Apr 24, 2020

Audited VictoryArea DefinitelyTyped props

  • Added origin
  • Removed labels and extended multilabelable props
  • Add number to label types

@maddles
Audit typescript props for VictoryArea. Add origin, change to multila…
22e1b13 
…bleable props from sinle, allow number as label type
@wsparsons wsparsons mentioned this pull request Apr 24, 2020
Closed
24 tasks
boygirl
boygirl approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@maddles maddles merged commit 60e0127 into master Apr 27, 2020
@maddles maddles deleted the task/audit-victory-area-typescript-props branch April 27, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@wsparsons wsparsons Awaiting requested review from wsparsons

@kale-stew kale-stew Awaiting requested review from kale-stew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddles @boygirl