Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DefinitelyTyped props for VictoryStack #1543

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Update DefinitelyTyped props for VictoryStack #1543

merged 1 commit into from
Apr 29, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented Apr 29, 2020 •
edited

Add the following props to VictoryStack:

  • children
  • fillInMissingData
  • origin

and remove the following redundant props:

  • domainPadding
  • horizontal

@maddles maddles marked this pull request as ready for review April 29, 2020 17:23
@wsparsons wsparsons mentioned this pull request Apr 29, 2020
Closed
24 tasks
boygirl
boygirl approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@maddles maddles merged commit e74676e into master Apr 29, 2020
@maddles maddles deleted the task/audit-victory-stack-props branch April 29, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@kale-stew kale-stew Awaiting requested review from kale-stew

@wsparsons wsparsons Awaiting requested review from wsparsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddles @boygirl