Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draggable demo, make sure DomainPropType is used where approriate #1551

Merged
merged 7 commits into from
May 5, 2020
Merged

Add draggable demo, make sure DomainPropType is used where approriate #1551

merged 7 commits into from
May 5, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented Apr 30, 2020

This PR:

  • Adds the draggable demo
  • Replaces object literals with DomainPropType where appropriate

@maddles maddles marked this pull request as draft May 1, 2020 16:03
@maddles maddles marked this pull request as ready for review May 4, 2020 23:06
boygirl
boygirl approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending merge conflict resolution

@maddles maddles merged commit 5980b49 into master May 5, 2020
@maddles maddles deleted the task/draggable-demo branch May 5, 2020 20:01
wsparsons
wsparsons approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@wsparsons wsparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! 🎉

packages/victory-core/src/index.d.ts
| { x?: DomainTuple; y: DomainTuple }
| { x: DomainTuple; y?: DomainTuple };
export type DomainPropType = DomainPropObjectType | DomainTuple;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for extracting this type out. it will make it easier to use the different domain types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@wsparsons wsparsons wsparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maddles @boygirl @wsparsons