Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audits and adds demo: ImmutableDemo #1552

Merged
merged 7 commits into from
May 5, 2020
Merged

Audits and adds demo: ImmutableDemo #1552

merged 7 commits into from
May 5, 2020

Conversation

wsparsons
Copy link
Member

@wsparsons wsparsons commented May 1, 2020 •
edited

  • Adds a typed ImmutableDemo
  • Updates type definition of the events prop for VictoryChart
  • Updates type definition of the style prop for VictoryTooltip

@wsparsons wsparsons marked this pull request as ready for review May 5, 2020 18:16
@wsparsons wsparsons requested review from maddles and boygirl May 5, 2020 18:27
@wsparsons wsparsons requested a review from boygirl May 5, 2020 22:39
boygirl
boygirl approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wsparsons wsparsons merged commit 2dfe113 into master May 5, 2020
@boygirl boygirl deleted the task/audit-immutable-demo branch June 23, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@maddles maddles Awaiting requested review from maddles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wsparsons @boygirl