Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export TextSize types from VictoryCore #1557

Merged
merged 2 commits into from
May 5, 2020
Merged

Export TextSize types from VictoryCore #1557

merged 2 commits into from
May 5, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented May 5, 2020

This PR adds an interface for TextSizeStyle and exports types for public TextSize methods

@maddles maddles requested review from wsparsons and boygirl May 5, 2020 20:52
boygirl
boygirl approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maddles maddles merged commit 9125a7b into master May 5, 2020
@maddles maddles deleted the task/text-size-types branch May 5, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@wsparsons wsparsons Awaiting requested review from wsparsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddles @boygirl