Fix / Tick Format w/ Domain #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing ticks while zooming
…he same way tickArray
|
@boygirl This solution seems to work, afaik. Please let me know how you feel about it though. It's a little funky, can maybe be prettied up a bit. |
jhumbug
changed the title
boygirl
reviewed
May 13, 2021
boygirl
reviewed
May 13, 2021
boygirl
reviewed
May 13, 2021
|
@jhumbug this is looking good, and works well. Approved! |
|
@boygirl thank you! merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug occurs when using tickFormat as an array while also restricting data points via domain (through props or through VictoryZoomContainer)
The ticks in VictoryAxis are altered by domain to determine which tick to display at which point on the axis. But when you also use a tickFormat array, the now shortened list of tickArray elements no longer corresponds with that unaltered tickFormat array.
This PR instead keeps track of the original indices of the filtered tickArray so that you can use it to also filter tickFormat in the same way.
When tickFormat is an array it must match the data array index for index to work correctly.