Feature/disable inline styles #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/disable inline styles
It turns out that the y-position of the label component is calculated using the inline font size. If there is no font size, the y-position will evaluate to NaN. For now, this fix continues to return the fontSize style attribute and use it as an inline style. If we want to calculate the size dynamically, that might be a bigger fix later.
…-styles Disable inline styles
boygirl
force-pushed
the
feature/disable-inline-styles
branch
from
8ddc2c0
to
a5f9b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new
disableInlineStylesboolean prop for folks styling their components by class name or using other solutions such asstyled-componentsCloses #1849