Fix (TypeScript): give datum
an any
type
#2436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The common props
x
,y
,y0
, andsortKey
allow for "accessor" functions, like:Currently, we have the
datum
arg typed asobject
, which doesn't allow for any property access nor strong types (see #2360).This PR allows for the type to be
any
. This seems like the best approach, since we currently don't know the shape of Datum, nor do we support generics with any of our components.This will allow the above code to function properly, as well as support manually-added types (like
(datum: MyData) => datum.xValue
).