Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed VictoryLine pointer events to default to 'stroke' #2530

Merged
merged 3 commits into from Dec 12, 2022

Conversation

gwynethrose
Copy link
Contributor

@gwynethrose gwynethrose commented Dec 8, 2022

Set VictoryLine to default to "pointer-events: stroke". This was causing issues with events firing incorrectly when lines overlapped (#2468) and also caused events to potentially fire in unexpected spots on the chart.

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

🦋 Changeset detected

Latest commit: 4884ce1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-line Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!
Any idea why the Chromatic report has so many minor changes? I'm assuming these are unrelated to this change, but I'd like if we could confirm that.

@scottrippey
Copy link
Member

Disregard the Chromatic diffs, they were changes from a previous PR that never got officially "accepted"

@gwynethrose gwynethrose merged commit 74b531d into main Dec 12, 2022
@victory-ci victory-ci mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants