Migrate victory-legend to TypeScript #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc15c98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KenanYusuf
commented
Jan 12, 2024
| type: string, | ||
| index: number, | ||
| index: string | number, |
There was a problem hiding this comment.
This can be a number, or a key of an object (string)
KenanYusuf
commented
Jan 12, 2024
| @@ -68,9 +68,9 @@ export interface EventsMixinClass<TProps> { | |||
| defaultAnimationWhitelist: string[], | |||
| ): React.ReactElement; | |||
| getComponentProps( | |||
| component: React.ReactElement, | |||
| component: React.ReactNode, | |||
There was a problem hiding this comment.
Used a more inclusive type for the component, as it can also be a string or string[]
30 tasks
carbonrobot
approved these changes
Jan 12, 2024
Merged
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
victory-legendpackage files to TypeScript