Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate victory-voronoi to TypeScript #2726

Merged
merged 1 commit into from Jan 19, 2024
Merged

Conversation

KenanYusuf
Copy link
Member

  • Migrate victory-voronoi to TypeScript
  • Fix a test

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 681a5f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-voronoi Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Jan 19, 2024 9:59am

@@ -176,8 +176,7 @@ describe("components/victory-voronoi", () => {

const labels = container.querySelectorAll("text");

// TODO: figure out why there's no labels rendering?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label prop should have been labels

@KenanYusuf KenanYusuf merged commit e42ba31 into main Jan 19, 2024
13 checks passed
@KenanYusuf KenanYusuf deleted the ts-migrate/victory-voronoi branch January 19, 2024 11:44
@victory-ci victory-ci mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants