Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2753 victoryarea events not triggering fill in docs #2755

Merged
merged 5 commits into from Jan 29, 2024
Merged

2753 victoryarea events not triggering fill in docs #2755

merged 5 commits into from Jan 29, 2024

Conversation

acharyakavita
Copy link
Contributor

@acharyakavita acharyakavita commented Jan 29, 2024 •
edited

Rename baseProps to newBaseProps and added new storybook testcases

@acharyakavita acharyakavita linked an issue Jan 29, 2024 that may be closed by this pull request
onClick Event handlers not triggering in docs #2753
Closed
2 tasks
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2024 •
edited

⚠️ No Changeset found

Latest commit: e9b6814

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 4:39pm

@acharyakavita acharyakavita merged commit c378f85 into main Jan 29, 2024
12 of 13 checks passed
@acharyakavita acharyakavita deleted the 2753-victoryarea-events-not-triggering-fill-in-docs branch January 29, 2024 16:52
@acharyakavita acharyakavita self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonrobot carbonrobot carbonrobot approved these changes

Assignees

@acharyakavita acharyakavita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onClick Event handlers not triggering in docs
2 participants
@acharyakavita @carbonrobot