Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate instances of lodash.assign to object.assign #2757

Merged
merged 5 commits into from Jan 30, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Jan 29, 2024

Replace instances of lodash.assign with Object.assign.

Functionally, in all our use cases these two methods are equivalent. The exception is that lodash.assign allows undefined as a first argument. The only case we had where this is an issue was events.ts where we simply check for undefined as a workaround. All other usages pass a new object as a first argument.

Also replaces usages of lodash.merge in the demo. We didn't use any specific to merge so its safe to use assign instead.

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 9d99dad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-voronoi Patch
victory-voronoi-container Patch
victory Patch
victory-create-container Patch
victory-vendor Patch
victory-zoom-container Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 3:20pm

@carbonrobot carbonrobot merged commit c8c2eb2 into main Jan 30, 2024
13 checks passed
@carbonrobot carbonrobot deleted the lodash/assign branch January 30, 2024 16:25
@victory-ci victory-ci mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Performance 📈 Issues related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants