Migrate instances of lodash.assign to object.assign #2757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace instances of
lodash.assign
withObject.assign
.Functionally, in all our use cases these two methods are equivalent. The exception is that
lodash.assign
allows undefined as a first argument. The only case we had where this is an issue was events.ts where we simply check for undefined as a workaround. All other usages pass a new object as a first argument.Also replaces usages of
lodash.merge
in the demo. We didn't use any specific to merge so its safe to use assign instead.