Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prop-types from many packages #2758

Merged
merged 11 commits into from Feb 5, 2024
Merged

Remove prop-types from many packages #2758

merged 11 commits into from Feb 5, 2024

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Jan 30, 2024

A lot of components have TypeScript types and propTypes declared with the prop-types package. This PR removes prop-types from many packages.

Relates to #2696

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 9c7eab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory Minor
victory-area Minor
victory-axis Minor
victory-bar Minor
victory-box-plot Minor
victory-brush-container Minor
victory-brush-line Minor
victory-candlestick Minor
victory-canvas Minor
victory-chart Minor
victory-core Minor
victory-cursor-container Minor
victory-errorbar Minor
victory-group Minor
victory-histogram Minor
victory-legend Minor
victory-line Minor
victory-native Minor
victory-pie Minor
victory-polar-axis Minor
victory-scatter Minor
victory-selection-container Minor
victory-shared-events Minor
victory-stack Minor
victory-tooltip Minor
victory-voronoi Minor
victory-voronoi-container Minor
victory-zoom-container Minor
victory-create-container Minor
victory-vendor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 9:42am

@KenanYusuf KenanYusuf merged commit 3877aa9 into main Feb 5, 2024
12 of 13 checks passed
@KenanYusuf KenanYusuf deleted the remove-prop-types branch February 5, 2024 08:09
@victory-ci victory-ci mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants