Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instances of lodash.range with native code #2760

Merged
merged 8 commits into from Jan 31, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Jan 30, 2024

Replace instances of lodash.range with equivalent native code. Includes tests built using comparisons to lodash as seen in the screenshot below.

Snapshot comparison

image

Relevant Code: https://github.com/FormidableLabs/victory/pull/2760/files#diff-40c5efad413c1e9989261214118a2c9e7d4de98b8b7b239f83778368f54e9991R220
Tests: https://github.com/FormidableLabs/victory/pull/2760/files#diff-1cf5b854b54e9f10213cc171a475a7d58b03f6006f4efdcb1eeba38811e0e8b6R206

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 649dd84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-area Patch
victory-bar Patch
victory-candlestick Patch
victory-core Patch
victory-errorbar Patch
victory-histogram Patch
victory-line Patch
victory-pie Patch
victory-scatter Patch
victory-voronoi Patch
victory-axis Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-group Patch
victory-legend Patch
victory-native Patch
victory-polar-axis Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 11:54am

@carbonrobot carbonrobot merged commit a53059f into main Jan 31, 2024
13 checks passed
@carbonrobot carbonrobot deleted the lodash/range branch January 31, 2024 15:18
@victory-ci victory-ci mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants