Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path alias to TS demo tsconfig #2771

Merged
merged 1 commit into from Feb 1, 2024
Merged

Conversation

KenanYusuf
Copy link
Member

The imports were all squiggly in the /demo/ts/* files due to webpack aliases being used, but no corresponding paths definitions in the tsconfig.

Before

Screenshot 2024-02-01 at 14 22 24

After

Screenshot 2024-02-01 at 14 22 38

Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 2e37f76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Feb 1, 2024 2:25pm

@KenanYusuf KenanYusuf merged commit d8b3660 into main Feb 1, 2024
10 checks passed
@KenanYusuf KenanYusuf deleted the ts-demos-import-alias branch February 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants