Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert victory-animation to function component #2788

Merged
merged 4 commits into from Feb 8, 2024

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Feb 7, 2024

Convert victory-animation to function component

Before

before.mp4

After

after.mp4

Copy link

changeset-bot bot commented Feb 7, 2024

🦋 Changeset detected

Latest commit: 5a9701d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 1:11pm

Copy link
Contributor

@carbonrobot carbonrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this, I'm adding some new storybook ui tests we can use as a comparison with main.

Copy link
Contributor

@carbonrobot carbonrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that. We are able to use the Demo to confirm. Looks good to me!

@KenanYusuf KenanYusuf merged commit c133086 into main Feb 8, 2024
10 checks passed
@KenanYusuf KenanYusuf deleted the victory-animation-function branch February 8, 2024 09:23
@victory-ci victory-ci mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants