Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to labelComponent prop in commonprops #2822

Merged
merged 1 commit into from Feb 23, 2024
Merged

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Feb 22, 2024

Description

It was pointed out in #2621 that VictoryBoxPlot doesn't support labelComponent. While we work on that enhancement and get feedback from the best way to move forward, I wanted to add a clarifying comment to the docs so that this information might be found more easily for other users.

Type of Change

  • This change requires a documentation update

How Has This Been Tested?

  • Verified link works when running locally.

Copy link

changeset-bot bot commented Feb 22, 2024

⚠️ No Changeset found

Latest commit: 1a51e69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Feb 22, 2024 11:32pm

@carbonrobot carbonrobot merged commit b3695c0 into main Feb 23, 2024
6 checks passed
@carbonrobot carbonrobot deleted the issue/2621 branch February 23, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants