Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear pipeline warnings #2836

Merged
merged 3 commits into from Mar 19, 2024
Merged

clear pipeline warnings #2836

merged 3 commits into from Mar 19, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Mar 19, 2024

Description

Upgrading our actions to remove node12 or node16 warnings.

actions/stale will likely still have a warning. To get to a version running on node20, there's some breaking changes that would affect what appears to be the desired behavior of our current stale action. Namely, in v7, the script no longer manages setting labels.

> Breaking Changes
In this release we prevent this action from managing the stale label on items included in exempt-issue-labels and exempt-pr-labels
We decided that this is outside of the scope of this action, and to be left up to the maintainer.

Edit: Hmm, on second thought I think I misinterpreted their message. I think it might be fine to upgrade to v9.
_Edit 2: I think we're fine to upgrade to v9 actually. I've done so.

If we're ok with that, I can upgrade it to v9 which would run on node20. However, since we're currently using those fields I'd imagine we want that behavior.

There doesn't seem to be a node 18 version out there. Doesn't seem like it would matter much either way.

Fixes https://github.com/orgs/FormidableLabs/projects/43/views/1?filterQuery=pi&pane=issue&itemId=55859714

Type of Change

  • cleanup

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 1928283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 8:33pm

@Burnett2k Burnett2k merged commit 300b527 into main Mar 19, 2024
6 checks passed
@Burnett2k Burnett2k deleted the chore/clear-pipeline-warnings branch March 19, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants