Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume range setting #34

Merged
merged 4 commits into from Jul 3, 2016

Conversation

chukysoria
Copy link
Contributor

Add a volume range setting -- useful for the Raspberry Pi's built-in DAC

@chukysoria
Copy link
Contributor Author

Fixes #22

@oschwede
Copy link

oschwede commented Mar 5, 2016

When I'm using --dbrange, a segfault happens when trying to access the webinterface. The funny thing is, when turning on debugging by using -d switch, the segfault does not happen anymore.

I'm running on Arch Linux, pyalsaaudio is 0.8.2. Any ideas what could cause this problem?

@maumi
Copy link

maumi commented Mar 5, 2016

Try to comment out
Print zerovars
in connect.py

@oschwede
Copy link

oschwede commented Mar 5, 2016

Thanks for your help :) After uncommenting it runs fine.

But I'm still wondering, why this issues appears when using --dbrange option, because non of the changes in this pull request affect the zeroconf code. When I have some time, I will try to investigate that.

@Fornoth
Copy link
Owner

Fornoth commented Mar 30, 2016

@chukysoria Pull request looks good, except can you change the option to represent it better, maybe something like --min-vol-range?
@oschwede if you can come to the gitter channel I can help you debug that (if you wanna get started, try running it like LD_LIBRARY_PATH=$PWD python -m trace -t --ignore-dir venv --ignore-dir /usr main.py)

@EyMaddis
Copy link

any updates?

@Fornoth
Copy link
Owner

Fornoth commented May 29, 2016

I'll try merging this in the next week or two

@oschwede
Copy link

I tried to debug the segfault today, but I cannot reproduce it anymore. Not even with the code from beginning of march. When I checkout this particular pull request with "git fetch origin pull/34/head:test && git checkout test", everythings is fine.

Avahi has been installed on my computer a few weeks ago, maybe that makes a difference? Although uninstalling Avahi does not bring back the segfault.

@Fornoth Fornoth merged commit 452da09 into Fornoth:master Jul 3, 2016
@Fornoth Fornoth mentioned this pull request Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants