Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less class change on 6.1 is broken #18835

Closed
adrienfr opened this issue Mar 18, 2022 · 7 comments
Closed

Less class change on 6.1 is broken #18835

adrienfr opened this issue Mar 18, 2022 · 7 comments
Assignees
Milestone

Comments

@adrienfr
Copy link

Hi,

Since v6.1, I think there is an issue with Less class attributes.
In v6.0 we had .fas, .fa-solid, .far, .fa-regular, ... but since v6.1, we have .fas, .fa--solid, .far, .fa-regular, ... .

Am I missing a configuration change somewhere? In v.6.1 all my FontAwesome icons are _italic because .fa-solid is not defined here but fa--solid :

Capture d’écran 2022-03-18 à 17 06 19

_
@tagliala
Copy link
Member

Hi!

Thanks for being part of the Font Awesome Community and thanks for reporting this issue.

Looks like an issue to me, let's assign @robmadole

@robmadole
Copy link
Member

Thanks @adrienfr we'll get this fixed up in 6.1.1.

@robmadole
Copy link
Member

@adrienfr I'm afraid this didn't make it in to 6.1.1. We'll try and get it into the next release though.

@adrienfr
Copy link
Author

Hi @robmadole, do you have any ETA for this fix to be released? Thanks

@robmadole
Copy link
Member

@adrienfr no ETA yet but it's slotted in for the next v6 release

@talbs
Copy link
Member

talbs commented Jun 28, 2022

Thanks for bringing this to our attention and apologies for the less than awesome Less compilation.

I've taken this off of @alexpoiry's hands and have a fix up for review. As @robmadole mentioned, this should be fixed in our next release shortly. I'll keep you folks posted once that's on its way out the door.

@robmadole
Copy link
Member

This fix is now released in 6.1.2. Give it a go everyone and let us know if you still have problems.

@tagliala tagliala added this to the 6.1.2 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants