Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Couldn't find package "@fortawesome/pro-duotone-svg-icons@^6.2.0" required by "child-repo-name version" on the "npm" registry #19336

Open
1 of 2 tasks
shaheryarkhan2021 opened this issue Sep 15, 2022 · 5 comments
Labels
bug needs-triage This bug needs to be confirmed

Comments

@shaheryarkhan2021
Copy link

Bug description

There is a parent repository and a child repository. Font-Awesome is self hosted in child repo and license in added in the child repo in .npmrc file. When I run yarn install in child repo everything installs successfully.
Child repo is added to the parent repo like this

Package.json of parent repo
    "child-repo-name": "ssh://path.git#v0.1.6"

when I run yarn install in the parent repo I receive this error
Bug: Couldn't find package "@fortawesome/pro-duotone-svg-icons@^6.2.0" required by "module-name version" on the "npm" registry

NOTE:
If I add .npmrc the license to parent repo and run yarn install it starts working the packages get installed as the license issue is resolved. But it shouldn't be the case. FontAwesome packages are installed in the child repo it should not request license from the parent. I have upgraded it from fontawesome-pro": "5.15.4" and in that version I wasn't having this issue

Child Package.json

  "dependencies": {
    "@fortawesome/fontawesome-svg-core": "^6.2.0",
    "@fortawesome/pro-duotone-svg-icons": "^6.2.0",
    "@fortawesome/pro-light-svg-icons": "^6.2.0",
    "@fortawesome/pro-regular-svg-icons": "^6.2.0",
    "@fortawesome/pro-solid-svg-icons": "^6.2.0",
    "@fortawesome/react-fontawesome": "^0.2.0",
    "@fortawesome/sharp-solid-svg-icons": "^6.2.0",

Reproducible test case

create a parent and child repo as mentioned above. put license in child repo and install it through parent using yarn install

Screenshots

No response

Font Awesome version

v6.2.0

Serving

Self-hosted

Implementation

SVG+JS

Browser and Operating System

Chrome on Linux

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@tagliala
Copy link
Member

my application get's used as a third-party

I'm getting the following:

There is a "Project A", with its own directory and package.json

"Project A" has a dependency on "Project B", which is listed into Project A's package.json

"Project B" has a dependency on Font Awesome Pro, and you expect that Project A can use Project B's Font Awesome license without configuration

In my understanding of node/npm, the .npmrc with the Font Awesome Pro token should be available into Project A, and there is no way it can work without a valid license.

Also, I have concerns that this use case configures into a redistribution of a Font Awesome Pro license

@robmadole any thoughts?

@shaheryarkhan2021
Copy link
Author

@tagliala @robmadole I am curious because when we were using the previous version "5.15.4" we didn't need to add .npmrc in "Project A" but now we need to.

@robmadole
Copy link
Member

@shaheryarkhan2021 the general setup of our NPM packages hasn't changed. Can you provide a reproducible example of what you are dealing with? I understand the basics but without seeing this work I'm not sure we'll be able to move forward.

@Calfur
Copy link

Calfur commented Aug 21, 2023

@shaheryarkhan2021 I could imagine that this issue did not occur in version "5.15.4" because you authenticated not with a .npmrc file but with the global setup?

https://fontawesome.com/v5/docs/web/setup/use-package-managers#global-set-up

@TimHuynh0905
Copy link

@shaheryarkhan2021 were you able to figure this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage This bug needs to be confirmed
Projects
None yet
Development

No branches or pull requests

5 participants