Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for new NPM Kits #422

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Document support for new NPM Kits #422

merged 4 commits into from
Feb 8, 2024

Conversation

robmadole
Copy link
Member

@robmadole robmadole commented Jan 18, 2024

@devoto13 We've got a new feature on fontawesome.com we are calling "Kit Packages". You can basically install your Font Awesome Kit using npm.

It has a different API that the old SVG icon packages.

I was about to merge this in without checking with you but then changed my mind.

Let me know what you think about this when you have a moment.

@robmadole robmadole changed the title Include new NPM Kits Document support for new NPM Kits Jan 31, 2024
@robmadole robmadole marked this pull request as ready for review January 31, 2024 19:07
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue with markdown, but otherwise LGTM

I don't have access to the FontAwesome Pro since I have changed jobs, so can't really test it, but I assume these packages come with type definitions, right? So they should work just fine in a TypeScript project.

docs/usage/explicit-reference.md Outdated Show resolved Hide resolved
docs/usage/icon-library.md Outdated Show resolved Hide resolved
docs/usage/using-other-styles.md Outdated Show resolved Hide resolved
@robmadole
Copy link
Member Author

I don't have access to the FontAwesome Pro since I have changed jobs, so can't really test it, but I assume these packages come with type definitions, right? So they should work just fine in a TypeScript project.

@devoto13 they do some with Typescript definitions. I'll look at #423 and see what's going on there.

@robmadole robmadole merged commit dd4690a into master Feb 8, 2024
2 checks passed
@robmadole robmadole deleted the npm-kits-docs branch February 8, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants