New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle bracket examples #109
Conversation
maxwondercorn
commented
Jun 1, 2019
- Added angle bracket examples to the readme
- Changed single quotes in examples to double quotes. Ember convention is double quotes in templates - single quotes are flagged during linting
- CONTRIBUTING.MD - Changed Angular references to Ember
Thanks for this @maxwondercorn! I think we can make the docs even better by dropping clasic If this seems like a good idea can you update all the test invocations to the new angle-bracket syntax as well? |
I think that is a great idea. I’ll work on it in a couple days including tests |
This PR is ready for review. I started the updates to CHANGELOG.md for the next version bump |
I didn't realize the addon was still testing against 2.18 which is the test failures. I can revert the test back to classic invocations or the PR can sit until the addon is upgraded to Ember 3.8. If you're following recommendations, only the last two LTS versions are tested. If we want to wait then I can rebase against master after the upgrade. Either one is fine with me, just let me know what you would like me to do. |
@maxwondercorn it looks like the addon blueprint for ember-cli 3.11 (which should get released any day now) does drop support for 2.18. I'll keep an eye on it and update and then you can update. I started #110 to get ahead of updates a bit. |
@maxwondercorn #111 unlocks this, can you rebase and tests should pass? Also you should remove your edits to the changelog as those will be generated with the release notes. |
@jrjohnson rebase completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks so much!