Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing properties in Typescript typedefs #151

Closed
Rycochet opened this issue Jul 3, 2018 · 1 comment
Closed

Missing properties in Typescript typedefs #151

Rycochet opened this issue Jul 3, 2018 · 1 comment

Comments

@Rycochet
Copy link

Rycochet commented Jul 3, 2018

Where this creates an SVG element, it doesn't (appear to) support any of the extra properties that are available and passed through - most notably onClick etc.

From the looks of the code it just passes through all unknown properties to the underlying React.CreateElement call.

I'm not sure if there's a best choice of what to do here, but the most inclusive one in this situation would be to change the Props interface slightly:

export interface Props extends DOMAttributes<SVGSVGElement> {
    ...
}
@dangayle
Copy link

Fixed with b63b1ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants