Add DOM attributes to FontAwesomeIconProps to Typescript definitions #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at previous PRs, I changed it to SVGSVGElement. Additionally, I added a backwards compatible Omit type to omit children and mask properties. |
|
If there is anything else needed to get this merged in feel free to let me know. |
|
@robmadole can you please take a look at this PR? Fixes: |
Rycochet
reviewed
Oct 17, 2019
Converted HTMLElement to SVGSVGElement and added backwards compatible Omit type
|
Rebased and squashed commits. |
|
Thanks @baelec this looks fine to me. Going to get this released now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of event handlers such as onClick, etc. If we want to limit ourselves to fairly recent versions of TS (or code our own which is fairly simple), we can use the omit type to omit the few types we don't need.
I didn't use SVGElement props as I'm not sure if that's a level of access we want to give but I can if desired.