Add title prop (#97) #180
Merged
Add title prop (#97) #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thank you. |
|
Does is work with server side rendering? https://github.com/FortAwesome/Font-Awesome/blob/ff2853acce00085b5830a050a2afa328fd212562/advanced-options/use-with-node-js/fontawesome-svg-core/index.js#L284-L290 |
|
See #93 @oliviertassinari |
|
Ok thanks, I'm facing the same issue on Material-UI side. It's what I thought. I will see what solution you go for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was what was meant by #97 !
Adding
<FontAwesomeIcon {...otherProps} title="Some Title" />Should add the title svg element to the rendered svg and add the aria-labelledby id of the title element to the svg element.