Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FA WP plugin 4.1.0 with WP 5.9 crash on update #159

Closed
TravelingTartar opened this issue Jan 27, 2022 · 9 comments
Closed

FA WP plugin 4.1.0 with WP 5.9 crash on update #159

TravelingTartar opened this issue Jan 27, 2022 · 9 comments

Comments

@TravelingTartar
Copy link

Upon install of 4.1.0, on a WP 5.9 site, the site blocked. Went in via recovery mode, deactivated and reactivated the plugin and it worked. Repeated and still had same problem. So now works, but only because I went in via recovery mode. Hope this helps.
@tagliala
Copy link
Member

Hi!

Thanks for being part of the Font Awesome Community.

The proper repository for this issue should be https://github.com/FortAwesome/wordpress-fontawesome, but I cannot transfer this issue

@mlwilkerson could you please take a look here and transfer the issue if you think it is the case?

@TravelingTartar
Copy link
Author

TravelingTartar commented Jan 27, 2022 via email

@tagliala
Copy link
Member

Hi, no problem 👍🏼

maybe we can improve that section in the future

@mlwilkerson
Copy link
Member

Hi @TravelingTartar. Thanks for the report. I suspect that this occurred because the plugin tries to refresh metadata about available releases for upgrades where the options database schema changes (as was the case in this release). And it may be that if many WordPress sites simultaneously do that upgrade, it puts an excessive load on the API server. We've introduced a couple of layers of caching to mitigate against that. But I wonder if there's a corner case I hadn't yet considered.

So I'm considering what corner case may be there, and also what would be a better way to handle this kind of upgrade.

It would help to know how you have the plugin configured. Specifically: have you added an API Token? Related (but separate), are you using the plugin with a Kit?

@mlwilkerson mlwilkerson transferred this issue from FortAwesome/Font-Awesome Jan 27, 2022
@mlwilkerson
Copy link
Member

Note to Self:

Initially, it seems mostly likely that the plugin upgrade triggered an excessive load on the API server, and blocking network requests to the server resulted in blocked page loads.

A possible solution is to avoid refreshing release metadata in try_upgrade(), unless necessary. And, thinking through various scenarios, it shouldn't be necessary, even when upgrading the data schema of the font-awesome or font-awesome-releases options schemas.

@mlwilkerson
Copy link
Member

@TravelingTartar It might also help to know whether you see any other "registered" themes or plugins on the Troubleshoot tab in this plugin's settings page.

@TravelingTartar
Copy link
Author

TravelingTartar commented Jan 27, 2022 via email

@mlwilkerson
Copy link
Member

@TravelingTartar your screenshot didn't come through with that attachment. But that's OK. I can work without it.

@mlwilkerson
Copy link
Member

I just release version 4.1.1 of the plugin that has simplified upgrade logic. In particular, it makes no network requests to refresh metadata from the API server upon upgrade. I think this is most likely the issue.

NOTE: I've not seen any problems with upgrading to 4.1.0 under WP 5.9. So I don't think there's an issue with WP 5.9 compatibility. If something else comes up for someone else, of course, we'll get a new investigation going on a new issue.

Thanks again for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tagliala @mlwilkerson @TravelingTartar