Add exact elasticsearch mapping #7440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a bug report where a search for "communism" (with and without quotes) was returning results for "community". This happens because elasticsearch stems both words into "commun", which is fine without quotes but totally incorrect with quotes.
This PR adds explicit mappings for all full-text fields to index them with two separate analyzers; one with stemming and synonyms and one without. Normal queries do not need to change, and we can now fix the bug when searching with quotes by simple appending
.exactto the field names. That is, the fieldbodynow contains the stemmed and synonynmed value, andbody.exacthas the unstemmed version.This PR requires running
Globals.elasticConfigureIndexes(). I've already done this on dev, but not staging or prod. It is safe to run before deploying.┆Issue is synchronized with this Asana task by Unito