Upgrade version of postgres-array #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres-array is a dependency of pg-types which is a depndency of pg. It's responsible for parsing jsonb fields in the results of queries we run in postgres. This version upgrade causes us to get the changes in bendrucker/postgres-array#16 , which makes that particular function ~2-3x faster. I observed that this function was ~2% of our server CPU time (on a benchmark where I was SSRing a post page with lots of comments in a loop), and after this upgrade I saw the time spent in it reduce accordingly. The version is a major version only because they dropped compatibility with some old nodejs versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres-array is a dependency of pg-types which is a depndency of pg. It's responsible for parsing jsonb fields in the results of queries we run in postgres. This version upgrade causes us to get the changes in bendrucker/postgres-array#16 , which makes that particular function ~2-3x faster. I observed that this function was ~2% of our server CPU time (on a benchmark where I was SSRing a post page with lots of comments in a loop), and after this upgrade I saw the time spent in it reduce accordingly.
The version is a major version only because they dropped compatibility with some old nodejs versions.
┆Issue is synchronized with this Asana task by Unito