[LW] Second Recombee Hybrid Tab for Admins #9176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0b3rt
reviewed
Apr 25, 2024
| @@ -177,13 +177,18 @@ const recombeeRequestHelpers = { | |||
| }; | |||
| }, | |||
|
|
|||
| convertHybridToRecombeeArgs(hybridArgs: HybridRecombeeConfiguration, hybridArm: keyof typeof HYBRID_SCENARIO_MAP, filter?: string) { | |||
| const { loadMore, userId, ...rest } = hybridArgs; | |||
| convertHybridToRecombeeArgs(hybridArgs: HybridRecombeeConfiguration, hybridArm: 'first' | 'second', filter?: string) { | |||
There was a problem hiding this comment.
If we're making this more generic, then why not just 0 | 1? Eliminates the translation on L187
b0b3rt
reviewed
Apr 25, 2024
|
|
||
| const isConfigurable = hybridArm === 'second'; | ||
| const clientConfig: Partial<Omit<HybridRecombeeConfiguration,"loadMore"|"userId">> = isConfigurable ? rest : {rotationRate: 0.1, rotationTime: 12}; | ||
| const prevRecommIdIndex = isConfigurable ? 1 : 0; |
There was a problem hiding this comment.
Is this supposed to be flipped?
b0b3rt
reviewed
Apr 25, 2024
| @@ -113,6 +113,7 @@ export interface RecombeeConfiguration { | |||
| rotationTime?: number, | |||
| booster?: string, | |||
| filter?: string, | |||
| hybridScenarios?: string[], | |||
There was a problem hiding this comment.
You can enforce that these are length of two by typing it as [string, string]
b0b3rt
reviewed
Apr 25, 2024
| @@ -127,6 +128,7 @@ export interface RecombeeRecommendationArgs extends RecombeeConfiguration { | |||
| } | |||
|
|
|||
| export interface HybridRecombeeConfiguration { | |||
| hybridScenarios: string[], | |||
There was a problem hiding this comment.
You can enforce that these are length of two by typing it as [string, string]
b0b3rt
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production has live a recombee recommendation list that's 50-50 emulate hacker news algo + recombee:personal logic.
This PR adds a second tab for comparison that's 50-50 emulate hacker news + custom-for-lw-recombee-logic that they made for us (has some tweakable parameters too in Recombee admin config on their site)
┆Issue is synchronized with this Asana task by Unito