update merge accounts script #9213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-cheng
commented
May 2, 2024
| [column, ` - '${fieldTokens[1]}'`], | ||
| ); | ||
| } else { | ||
| throw new Error(`Unsetting a field past the first level of a JSON blob is not yet supported`) |
There was a problem hiding this comment.
As far as I can tell, we don't unset past the first level anywhere so I decided to just fix the easy case
jpaddison3
approved these changes
May 3, 2024
| @@ -189,6 +189,10 @@ Vulcan.mergeAccounts = async ({sourceUserId, targetUserId, dryRun}: { | |||
|
|
|||
| // Transfer posts | |||
| await transferCollection({sourceUserId, targetUserId, collectionName: "Posts", dryRun}) | |||
| // Transfer post co-authorship | |||
| if (!dryRun) { | |||
There was a problem hiding this comment.
Why is this the only check for dryRun?
There was a problem hiding this comment.
There are some things in this script that already follow this pattern, like moveUserConversationsToNewUser(). We could add dryRun versions for those things (ideally this script would have those) but I felt like this PR had enough changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few issues when I tried to merge two accounts, so here is my attempt to fix them:
userIdfield in message (and other table)contentsdidn't get updated to the new account, although the messageuserIdvalues did get properly updated (but this may cause issues if we normalize thecontentsfield)services.resume, though I'm not 100% confident. In any case, after I updatedcompileUpdateField()to fix issue (2) above, the unsetting was definitely not working in my testing, so I've updated the function to properly handle unsettingservices.resume.┆Issue is synchronized with this Asana task by Unito