Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Windows #26

Closed
DatL4g opened this issue Aug 17, 2022 · 4 comments
Closed

Not compatible with Windows #26

DatL4g opened this issue Aug 17, 2022 · 4 comments
Milestone

Comments

@DatL4g
Copy link
Contributor

DatL4g commented Aug 17, 2022

Describe the bug

Not sure if it's a bug or a feature request.

However I recently discovered that Ktorfit isn't compatible with Windows.
I contributed to another project and everything worked fine for me (as I'm on Linux) but another person (using Windows) could not retrive the native library as it's not published for the windows target.

To Reproduce

Steps to reproduce the behavior:

  1. Create a native library/application
  2. Boot into a Windows machine
  3. Open and build the project
  4. See error

Expected behavior

The library should be available on the Windows platform.

I saw that the gradle files are missing the Windows target, adding it should resolve the problem.

@hadiyarajesh
Copy link

@Foso I'm that person using Windows machine. Let me know if you need more error details.

@Foso
Copy link
Owner

Foso commented Aug 17, 2022

Thank you for reporting, i forgot it, because i usually don't develop on Windows. But i think it will be easy, to add it as a target

Foso added a commit that referenced this issue Aug 17, 2022
@Foso Foso added this to the 1.0-beta10 milestone Aug 17, 2022
Foso added a commit that referenced this issue Aug 17, 2022
@Foso
Copy link
Owner

Foso commented Aug 18, 2022

hey, @DatL4g @hadiyarajesh i just released a new version that has the windows target

@DatL4g
Copy link
Contributor Author

DatL4g commented Aug 18, 2022

@Foso thanks.

Unfortunately we need #31 too... hehe
Anyways thanks for adding Windows target

@Foso Foso closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants