need safe response converter

[yang961226]

Retrofit's Response Converter supports converting the abnormal result into a successful result when an exception occurs during the network request process, but Ktorfit currently can only convert the case where no exception occurs, which makes me have to use try-catch to wrap For the request method, can I add a Converter so that I can continue to convert the result when the request reports an error instead of directly causing the framework to throw an exception

[Foso]

Hi, are you looking from something like de.jensklingenberg.ktorfit.Response ?

interface ExampleApi{
  suspend fun getUser(): Response<User>
}

val userResponse = userKtorfit.create<ExampleApi>().getUser()
    
if(userResponse.isSuccessful){
  userResponse.body()
}else{
  userResponse.errorBody()
}

[Ric-AB]

In addition, when using response converter, I currently can't see any way to handle non-http exceptions from the docs. For example if there's no connectivity, UnresolvedHostException is thrown there's no way to handle such exceptions using response converters.

[yang961226]

What @Ric-AB said exactly what I wanted to say, UnresolvedHostException unable to handle non-Http exceptions,it just throw the exception and no way to handle it.

[Foso]

Hi, i understand the need for that feature and will make it work to handle these exception from inside a converter