Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google pixel month view #154

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Fix google pixel month view #154

merged 2 commits into from
Mar 10, 2024

Conversation

jonas-w
Copy link
Contributor

@jonas-w jonas-w commented Feb 18, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • The problem was that the screen width is exactly divisible by 7 (the number of days in one row/week), so in line 77 (where it was < instead of <=) it instead wrapped the last element always to the next line.
  • Removed redundant position calculations, as they are instantly altered by the onLayout function, so they are not even used. (can be reverted if not wanted, as these changes don't affect the bug fix)

Before/After Screenshots/Screen Record

  • Before:
    As you can see the dates on the right don't have this bounding box which is clickable, and the boxes also went out of the visible area at the bottom.
    image

  • After:
    Now every date has a bounding box that is clickable and no boxes are below the visible area.
    image

Fixes the following issue(s)

Acknowledgement

@naveensingh
Copy link
Member

Hey, thanks for the bug fix. I'll check it soon.

@topcaser
Copy link

Perfect and thanks a lot that a fix is available since this problem bothered me already in SMT and forced me to switch to Etar. When are you going to check the commit?

@popogomo
Copy link

popogomo commented Mar 6, 2024

Any update on this by a chance? Thanks.

@naveensingh
Copy link
Member

Not enough fuel and too much spacetime. I'm looking at it now...

@naveensingh naveensingh merged commit f70268b into FossifyOrg:master Mar 10, 2024
@naveensingh
Copy link
Member

The logic sounds solid and works fine on the devices I tested. @jonas-w Good work and thanks!

This probably also happened on rare devices with non-standard display widths like 1050, 1176, 1260, etc. but those are more common in iPhones. Google is copying everything now.

@jonas-w
Copy link
Contributor Author

jonas-w commented Mar 10, 2024

@naveensingh no worries, thanks for merging!

@jonas-w jonas-w deleted the fix/google_pixel_bug branch March 10, 2024 19:54
@jonas-w
Copy link
Contributor Author

jonas-w commented Mar 10, 2024

@naveensingh any ETA for a new release of Calendar, so the Google Pixel 8 users can continue using the Fossify Calendar?

@naveensingh
Copy link
Member

@jonas-w today is the day.

@popogomo
Copy link

@naveensingh Thanks a million for this! I know its not easy to maintain so many apps and resolve the issues, so appreciate your efforts greatly!

@naveensingh
Copy link
Member

@jonas-w https://github.com/FossifyOrg/Calendar/releases/tag/1.0.3

@popogomo
Copy link

@jonas-w https://github.com/FossifyOrg/Calendar/releases/tag/1.0.3

@jonas-w @naveensingh Just updated and its working as expected. Thanks a million guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touch is broken for Pixel 8 Pro
4 participants