-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: added Sorting dialog to the timer tab #67
base: master
Are you sure you want to change the base?
Conversation
Compare your solution to what's already in Alarms, because it behaves a bit differently:
|
My PR did not add those, they were already there, I just added sorting. |
But there was no sorting before, so no one could see this behavior. I know you've just added sorting, but while adding a new feature, we should make sure that it behaves the same as in other places. |
Should I add animation to the alarms or remove it from the timers? |
Don't add animation and remove it from Timers. We don't have animations while sorting in other apps. |
@Aga-C I managed to remove the animation, but the auto scrolling I haven't figured out yet, I will try again later, but though I will say it here and maybe someone can share a tip or an idea. |
I move to MyRecyclerViewAdapter for the TimerAdapter to be consistent with the AlarmsAdapter, no visual changes, but now we have no animations and the list does not scroll to the bottom. |
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Acknowledgement