Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically exported .VCF can't be imported #31

Closed
6 tasks done
hetszunyukapanyanyimonyok opened this issue Jan 22, 2024 · 13 comments · Fixed by #34
Closed
6 tasks done

Automatically exported .VCF can't be imported #31

hetszunyukapanyanyimonyok opened this issue Jan 22, 2024 · 13 comments · Fixed by #34
Labels
ASAP Issue needs to be fixed as soon as possible. bug Something is not working

Comments

@hetszunyukapanyanyimonyok
Copy link

hetszunyukapanyanyimonyok commented Jan 22, 2024

Checklist

  • I can reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Describe the bug
Trying to import one of the daily automatically backed up .vcf file.
It fails every time.
I have tried other days backup, does not help.
If I export manually, that works as normal import.
(But that is not efficient enough)

To Reproduce
Steps to reproduce the behavior:

  1. Import automatically exported .vcf file.
  2. Import failes.

Expected behavior
To able to import,
automatically exported .vcf files.

Device info (please complete the following information):

  • OS: [e.g. Android 11]
  • app version 1.0.1

Additional context
So i have analyzed the manually and the automatically exported .vcf files.
Their data structures are Totally different.
Because the manual works I did not touch it.
Than I tried to clean/the automatic backed up one/ by allowing only 1 contact
(Without extra infos for example: address; email etc.) and that failed too so based on this
the automatically exported files must be broken by default.

@Aga-C
Copy link
Member

Aga-C commented Jan 22, 2024

Can you send an example of a non-working VCF file (anonymized)?

@Aga-C Aga-C added bug Something is not working question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Jan 22, 2024
@hetszunyukapanyanyimonyok
Copy link
Author

@Aga-C
Hi! I have uploaded it in tresorit because GitHub does not support this file format if you need it I can email it or any solution that you have.

https://web.tresorit.com/l/JVxKp#_tBTZOJv6oTr0PAapeHLhw

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 22, 2024
@Aga-C Aga-C removed question Further information is requested needs triage Issue is not yet ready for PR authors to take up labels Jan 22, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 22, 2024

Thanks! It looks that you got JSON exported instead of VCF. It surely needs to be fixed.

@Aga-C Aga-C added the ASAP Issue needs to be fixed as soon as possible. label Jan 22, 2024
naveensingh added a commit that referenced this issue Jan 22, 2024
@naveensingh
Copy link
Member

The feature was originally added at SimpleMobileTools/Simple-Contacts#998
and SimpleMobileTools/Simple-Commons#1739 but I have no idea why the contacts were exported in JSON.

@Merkost Do you remember why it was done that way or was it just a mistake? Sorry for the ping :)

@Merkost
Copy link
Contributor

Merkost commented Jan 22, 2024

The feature was originally added at SimpleMobileTools/Simple-Contacts#998
and SimpleMobileTools/Simple-Commons#1739 but I have no idea why the contacts were exported in JSON.

@Merkost Do you remember why it was done that way or was it just a mistake? Sorry for the ping :)

Hi there,
Json is used for app backups. It's standardized within all Simple apps.
Vcf's are used for basic contract exports.
The vcf format doesn't support the app's custom fields, that's why the backup is in this format.

@hetszunyukapanyanyimonyok
Copy link
Author

@Merkost Hi, sorry my two cents question:
Than why the manual export is in simple .vcf format and works when imported?
(with hidden fields too)

@Merkost
Copy link
Contributor

Merkost commented Jan 22, 2024

@Merkost Hi, sorry my two cents question:
Than why the manual export is in simple .vcf format and works when imported?
(with hidden fields too)

It will work, as the hidden fields are not custom ones

@HarriBuh
Copy link

Yes, this one here is an old bug from SimpleTools. I remember several opened issue threads about it (including mine) and it hasn't been tackled ever since.

@naveensingh
Copy link
Member

Since VCF is a well-known file format, it makes sense for automatic backup exports to be in that format.

@abdo2048
Copy link

abdo2048 commented Feb 2, 2024

Hi, I wanted to open new issue but maybe I could mention my problem here and I will open new issue if you need me to do so.
As I understand, Automatic Backup Feature should backup the contacts (whether in vcf or json format as in this discussion) when a new contact is added, right?
But the Automatic Backup Feature doesn't work with me at all! No files exported (vcf or json).

What I tried but the automatic backup didn't do anything:

  1. Adding new contact using Fossify Contacts app to my Samsung email.
  2. Adding new contact using Fossify Contacts app to my phone storage (which is not visible to other apps)
  3. Adding new contact using Samsung Contacts app to my Samsung email.
  4. Changed the path/folder of backup.

Device info
OS: Android 14 (Samsung - One UI v6.0)
App version: 1.0.1

@Aga-C
Copy link
Member

Aga-C commented Feb 2, 2024

@abdo2048 Automatic backup runs once a day.

@abdo2048
Copy link

abdo2048 commented Feb 2, 2024

@Aga-C Sorry, I didn't know that.
I think it would be better to show this piece of info in the app, I mean a phrase should be written in Settings under BACKUPS section that indicates the backup happens one time each day.
And I believe adding the flexibility of choosing when to backup (Scheduling backups) would be great too.
Thank you so much.

@franco-bez
Copy link

Since VCF is a well-known file format, it makes sense for automatic backup exports to be in that format.

aggreed.

what make me wonder is that the "fix" was implemented in January, but the bug is still there in July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP Issue needs to be fixed as soon as possible. bug Something is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants