Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling cover image instead of cropping #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Scaling cover image instead of cropping #42

wants to merge 1 commit into from

Conversation

jchaves
Copy link

@jchaves jchaves commented Mar 26, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Changing the way Cover art is shown. As far as I can tell, it works the same for "square-ish" covers, but improves it for "portrait mode" images.
  • Feel free to reject it and just implement the idea if you'd rather (as you can see, there's already a not applied code stub where I started trying to get a "zoom in" feature, but I'm quite rusty on all things Android)

Before/After Screenshots/Screen Record

  • Before:
  • Sin título
  • After:
  • Sin título

Fixes the following issue(s)

Acknowledgement

@knuxyl
Copy link

knuxyl commented Apr 21, 2024 •
edited

I tested this and it's working, but i think there should be some padding at the top because it goes behind the notifcation bar and it gets hard to read stuff up there. Not a big deal though and isn't really related to this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect cover art aspect ratio (e.g., for audiobooks
2 participants
@jchaves @knuxyl