Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect cover art aspect ratio (e.g., for audiobooks #41

Open
6 of 7 tasks
jchaves opened this issue Mar 26, 2024 · 0 comments · May be fixed by #42
Open
6 of 7 tasks

Respect cover art aspect ratio (e.g., for audiobooks #41

jchaves opened this issue Mar 26, 2024 · 0 comments · May be fixed by #42
Labels
enhancement New feature or request

Comments

@jchaves
Copy link

jchaves commented Mar 26, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Currently, track covers are displayed in a, mostly, square format, with top and bottom cropped out for images that are "portrait" mode. (I listen to audiobooks on this app, and it shows only the center of the cover)

Diaplaying the full cover in these cases could be neat

Why do you want this feature?

I would like to be able to see the full cover when they are not "square-ish"

Additional information

I have made some "testing" changes that I'll include in a pull review so you can check what I mean. Something like:
Current:
Sin título
Change already "working":
Sin título
Optional? click on the cover image to expand, maybe? (work in progress, I need to get familiar with android stuff :) )
Sin título

@jchaves jchaves added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Mar 26, 2024
@jchaves jchaves linked a pull request Mar 26, 2024 that will close this issue
4 tasks
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants