-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orders without associated Customer causes error when syncing from ShipStation #18
Comments
|
With this I was wondering if the order has all the info it needs (name, address, product, etc...) can it sync anyway? Or skip the ones that don't meet the requirements rather than stop all orders being synced. |
@Adamascroft We're already checking for shipping and billing addresses here: https://github.com/FosterCommerce/shipstation-connect/blob/master/src/services/Xml.php#L19-L24 public function shouldInclude($order)
{
$settings = Plugin::getInstance()->settings;
$billingSameAsShipping = $settings->billingSameAsShipping;
return $order->getShippingAddress() && ($billingSameAsShipping || $order->getBillingAddress());
} We can add a condition to require a customer on an order. I think it's fine to exclude orders without customers as ShipStation requires the |
An error occurred attempting to update orders: The remote server returned an error: (500) Internal Server Error.
The test connection goes through as if it's connected and working.
Craft Pro | 3.4.20
Craft Commerce | 3.1.4
ShipStation | 1.3.2
The text was updated successfully, but these errors were encountered: