Add a optional parameter for MessagePackSerializer to determine whether compress the serialized data. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er compress the serialized data.
niemyjski
approved these changes
Jan 25, 2018
|
|
||
| public MessagePackSerializer(IFormatterResolver resolver = null) { | ||
| public MessagePackSerializer(IFormatterResolver resolver = null, bool compressEnabled = false) { |
There was a problem hiding this comment.
should this be called useCompression ? or should we have a serializer settings class for this (do we see more options being used here)?
| } | ||
|
|
||
| public object Deserialize(Stream input, Type objectType) { | ||
| return MessagePack.MessagePackSerializer.NonGeneric.Deserialize(objectType, input, _formatterResolver); | ||
| if (_compressEnabled) { |
There was a problem hiding this comment.
On a side note, I need to work on coding style guide but we try to have single statements not have braces and K&R coding style (everything on same line } else {
|
Looks good, only had a question about the parameter. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #118