Support for UniqueId on QueueEntryOptions (with MessageBus support) #268
Conversation
…ions synchronously
…o subscribers fails
…o FoundatioFx-master
|
|
||
| namespace Foundatio.Messaging { | ||
| public interface IMessagePublisher { | ||
| Task PublishAsync(Type messageType, object message, TimeSpan? delay = null, CancellationToken cancellationToken = default); | ||
| Task PublishAsync(Type messageType, object message, TimeSpan? delay = null, QueueEntryOptions options = null, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Why are we passing in a QueueEntryOptions into a messaging implementation?
There was a problem hiding this comment.
Yeah, this is a breaking change. We can't really change this.
There was a problem hiding this comment.
I did wonder about this. Does it need a MessageEntryOptions instead then?
There was a problem hiding this comment.
To be clear, either there is some sort of breaking change or we go back to having the message object itself implement an known interface in order to provide the unique message id (but you guys suggested otherwise in FoundatioFx/Foundatio.AzureServiceBus#39 unless I misunderstood your intent).
Unless you can think of another option?
There was a problem hiding this comment.
@niemyjski and @ejsmith
Any steer on what you would like to do with this?
There was a problem hiding this comment.
Yeah I primarily need it for messaging but I do use both. I've had to essentially fork your code to be able to use it for our purposes (with the duplicate detection) but I was hoping it was useful enough to incorporate into the packages and consume them that way so I didn't diverge over time and create a maintenance issue.
Happy to take your steer on what to do? Go back to the interface? Wait till you've had time to consolidate?
There was a problem hiding this comment.
I am hoping to get time to work on the consolidation soon, but I think it the meantime, if you wanted to submit a PR that makes the IMessagePublisher more like the queue one where we have MessageOptions like you suggested as a parameter similar to how we have QueueEntryOptions on queues now. That way we aren't adding a parameter to the contract for a single feature.
There was a problem hiding this comment.
Ok thanks. I'll try and get that together over the next few days (time permitting).
There was a problem hiding this comment.
@ejsmith I've updated this PR (and the ones in the other repositories) with a MessageOptions instead. Let me know what you guys think.
The other PR's are:
There was a problem hiding this comment.
It's looking good. Thanks for your efforts with this!
Driven by the need to have duplicate detection functionality Azure Service Bus (see FoundatioFx/Foundatio.AzureServiceBus#39).
Adds a
UniqueIdproperty to theQueueEntryOptionsclass and supports passing options publishing a message to anIMessageBus.