Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send work item failed progress messages #284

Merged
merged 7 commits into from Jan 9, 2023
Merged

Send work item failed progress messages #284

merged 7 commits into from Jan 9, 2023

Conversation

akshay-zz
Copy link
Contributor

Fix #76

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@akshay-zz akshay-zz marked this pull request as ready for review January 2, 2023 11:03
@niemyjski niemyjski requested a review from ejsmith January 2, 2023 21:39
ejsmith
ejsmith requested changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@ejsmith ejsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some feedback

@akshay-zz akshay-zz requested a review from ejsmith January 3, 2023 12:22
ejsmith
ejsmith approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@ejsmith ejsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niemyjski niemyjski merged commit d01bb12 into FoundatioFx:master Jan 9, 2023
@niemyjski
Copy link
Member

Thanks for the PR!

@akshay-zz akshay-zz deleted the failed-progress-message branch January 9, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejsmith ejsmith ejsmith approved these changes

@niemyjski niemyjski niemyjski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send work item failed progress messages
4 participants
@akshay-zz @CLAassistant @niemyjski @ejsmith