Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

represent an aggregation function using a set of aggregation keys rather than a KeyExpression #1175

Closed
normen662 opened this issue Mar 11, 2021 · 0 comments
Assignees

Comments

@normen662
Copy link
Contributor

Currently the class IndexAggregateFunction (and derivates) use a KeyExpression called operand to represent both grouping expressions, and grouped expressions (the aggregate function's argument(s)). We also allow for certain attributes of this class, specifically index to be nulled out or not. In general it appears as if there are two different versions of objects created from this class:

  1. function objects that do not have an index (they are unbound)
  2. function objects that do have an index set (they are bound to that said index)

Interestingly, there is no point fixing the order of the grouping expressions when such a function is not yet bound to an index as the index dictates the order of these expressions.

This issue should target the separation of these two use cases into two actual classes, one for the bound and one for the unbound case. In the unbound case we want to represent the grouping keys in set rather than positionally fixed.

@normen662 normen662 self-assigned this Mar 11, 2021
@normen662 normen662 changed the title represent an aggregation function as using a set of aggregation keys rather than a list represent an aggregation function as using a set of aggregation keys rather than a KeyExpression Mar 11, 2021
@normen662 normen662 changed the title represent an aggregation function as using a set of aggregation keys rather than a KeyExpression represent an aggregation function using a set of aggregation keys rather than a KeyExpression Mar 11, 2021
@MMcM MMcM closed this as completed in f769830 Mar 16, 2021
MMcM added a commit that referenced this issue Mar 16, 2021
Resolves #1175: represent an aggregation function using a set of a…
normen662 added a commit to normen662/fdb-record-layer that referenced this issue Mar 18, 2021
MMcM added a commit that referenced this issue Mar 18, 2021
Resolves #1175: represent an aggregation function as using a set of a…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant