Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use either record count or estimated size when determining IndexStatus in checkVersion #1239

Closed
alecgrieser opened this issue Apr 16, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@alecgrieser
Copy link
Contributor

When the estimated size is exposed (see #1229), we should also allow users to use it in checkVersion instead of the record count. The size could, in theory, be more useful on record stores that don't have an appropriate index (or for whom executing a query against the index is too costly).

I think there's a way to make this backwards compatible. At some point, we may want to make using the size the default. However, there are also some unknowns about the performance of this on large stores, so until we know that for sure, I think it should be opt-in.

To make this backwards compatible, I propose adding a new method to the UserVersionChecker that takes the count and size as parameters, and then by default, it just calls the existing method. The checkVersion logic can then call the new method. Because we're not sure of the performance (and because we also don't want to do extra work), I propose that we make both lazy (i.e., a supplier of type CompletableFuture).

Hopefully, this could then be used by a user to solve #7.

@alecgrieser alecgrieser self-assigned this Apr 16, 2021
@alecgrieser alecgrieser added the enhancement New feature or request label Apr 16, 2021
@alecgrieser alecgrieser added this to the 3.0 milestone Apr 16, 2021
ScottDugas added a commit that referenced this issue Jul 8, 2021
…by-size

Resolves #1239: Use either record count or estimated size when determining IndexStatus in checkVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant