You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
planOther is not called when there is no filter at all. But the only filter(s) might be on the grouping key(s).
The code does the correct thing today. A single filter will not match getQueryForFilter. And an And will fail to match any of its children. However, that child filter check lacks a comment about why it is there, in as much as this is policy and not correctness.
So mostly this is about documentation and tests.
Still, it is possible to determine that the passed-on filter only had group filters after initially matching them and stop.
The text was updated successfully, but these errors were encountered:
planOther
is not called when there is no filter at all. But the only filter(s) might be on the grouping key(s).The code does the correct thing today. A single filter will not match
getQueryForFilter
. And anAnd
will fail to match any of its children. However, that child filter check lacks a comment about why it is there, in as much as this is policy and not correctness.So mostly this is about documentation and tests.
Still, it is possible to determine that the passed-on filter only had group filters after initially matching them and stop.
The text was updated successfully, but these errors were encountered: