Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene scans without queries #1674

Closed
MMcM opened this issue May 16, 2022 · 0 comments
Closed

Lucene scans without queries #1674

MMcM opened this issue May 16, 2022 · 0 comments
Assignees

Comments

@MMcM
Copy link
Contributor

MMcM commented May 16, 2022

planOther is not called when there is no filter at all. But the only filter(s) might be on the grouping key(s).

The code does the correct thing today. A single filter will not match getQueryForFilter. And an And will fail to match any of its children. However, that child filter check lacks a comment about why it is there, in as much as this is policy and not correctness.

So mostly this is about documentation and tests.

Still, it is possible to determine that the passed-on filter only had group filters after initially matching them and stop.

@MMcM MMcM self-assigned this May 16, 2022
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue May 16, 2022
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue May 18, 2022
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue May 23, 2022
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue May 25, 2022
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue May 25, 2022
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant