Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online Indexer: Index from index: allow fallback to by-record if previous stamp is multi-target #1736

Closed
jjezra opened this issue Jun 16, 2022 · 0 comments · Fixed by #1737
Closed

Online Indexer: Index from index: allow fallback to by-record if previous stamp is multi-target #1736

jjezra opened this issue Jun 16, 2022 · 0 comments · Fixed by #1737

Comments

@jjezra
Copy link
Contributor

jjezra commented Jun 16, 2022

If an index was partly built as multi target, and a by-index indexing is attempted (with the appropriate continue previouse permissions) - allow fallback to a by-record indexing.
This will be consistent with:

  1. We allow this fallback if the previous stamp is BY_RECORDS
  2. We allow BY_RECORD continue a MULTI_TARGET_BY_RECORDS session
jjezra added a commit to jjezra/fdb-record-layer that referenced this issue Jun 16, 2022
@jjezra
Resolve FoundationDB#1736: Online Indexer: Index from index: allow fa…
2a310d6 
…llback to by-record if previous stamp is multi-target

   This will be consistent with the existing:
        Allowing this fallback if the previous stamp is BY_RECORDS
        Allowing BY_RECORD continue a MULTI_TARGET_BY_RECORDS session
jjezra added a commit to jjezra/fdb-record-layer that referenced this issue Jun 16, 2022
@jjezra
Resolve FoundationDB#1736: Online Indexer: Index from index: allow fa…
be2242b 
…llback to by-record if previous stamp is multi-target

   This will be consistent with the existing:
        Allowing this fallback if the previous stamp is BY_RECORDS
        Allowing BY_RECORD continue a MULTI_TARGET_BY_RECORDS session
@alecgrieser alecgrieser linked a pull request Jun 16, 2022 that will close this issue
Resolve #1736: Online Indexer: Index from index: allow fallback to by… #1737
Merged
alecgrieser pushed a commit that referenced this issue Jun 16, 2022
@jjezra
Resolve #1736: Online Indexer: Index from index: allow fallback to by… (
e147a6f 
#1737)

* Resolve #1736: Online Indexer: Index from index: allow fallback to by-record if previous stamp is multi-target

   This will be consistent with the existing:
        Allowing this fallback if the previous stamp is BY_RECORDS
        Allowing BY_RECORD continue a MULTI_TARGET_BY_RECORDS session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #1736: Online Indexer: Index from index: allow fallback to by… jjezra/fdb-record-layer
1 participant
@jjezra