Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing index data can skip uniqueness violations space on non-unique indexes #1973

Closed
alecgrieser opened this issue Jan 24, 2023 · 0 comments · Fixed by #1976
Closed

Clearing index data can skip uniqueness violations space on non-unique indexes #1973

alecgrieser opened this issue Jan 24, 2023 · 0 comments · Fixed by #1976
Assignees
@alecgrieser
Labels
performance Performance issues

Comments

@alecgrieser
Copy link
Contributor

At the moment, the clearIndexData method will clear out the uniqueness violations space on all indexes. However, this space is only updated if the index is unique, and it only needs to be read when updating a unique index. We should be able to avoid a few clears and a range scan on non-unique indexes.
@alecgrieser alecgrieser added the performance Performance issues label Jan 24, 2023
@alecgrieser alecgrieser self-assigned this Jan 24, 2023
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Jan 25, 2023
@alecgrieser
Resolves FoundationDB#1973: Clearing index data can skip uniqueness v…
514d479 
…iolations space on non-unique indexes

When clearing out index data, we don't really need to clear out the list of uniqueness violations on non-unique indexes, as that data is only consulted by unique indexes. This skips clearing out that space for those indexes, and it also adjusts the `scan` method to only ask unique indexes for violations.

This resolves FoundationDB#1973.
@alecgrieser alecgrieser mentioned this issue Jan 25, 2023
Merged
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Feb 1, 2023
@alecgrieser
Resolves FoundationDB#1973: Clearing index data can skip uniqueness v…
b64143f 
…iolations space on non-unique indexes

When clearing out index data, we don't really need to clear out the list of uniqueness violations on non-unique indexes, as that data is only consulted by unique indexes. This skips clearing out that space for those indexes, and it also adjusts the `scan` method to only ask unique indexes for violations.

This resolves FoundationDB#1973.
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Feb 6, 2023
@alecgrieser
Resolves FoundationDB#1973: Clearing index data can skip uniqueness v…
09b9d9d 
…iolations space on non-unique indexes

When clearing out index data, we don't really need to clear out the list of uniqueness violations on non-unique indexes, as that data is only consulted by unique indexes. This skips clearing out that space for those indexes, and it also adjusts the `scan` method to only ask unique indexes for violations.

This resolves FoundationDB#1973.
ScottDugas added a commit that referenced this issue Feb 6, 2023
@ScottDugas
Merge pull request #1976 from alecgrieser/01973-avoid-clearing-unique…
c726d05 
…ness-space

Resolves #1973: Clearing index data can skip uniqueness violations space on non-unique indexes
@alecgrieser alecgrieser mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecgrieser alecgrieser

Labels
performance Performance issues
Projects
None yet
Milestone
No milestone
1 participant
@alecgrieser