Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log store timer metrics during indexer progress log message #1984

Closed
alecgrieser opened this issue Jan 30, 2023 · 0 comments · Fixed by #1988
Closed

Log store timer metrics during indexer progress log message #1984

alecgrieser opened this issue Jan 30, 2023 · 0 comments · Fixed by #1988
Assignees
@alecgrieser
Labels
performance Performance issues

Comments

@alecgrieser
Copy link
Contributor

alecgrieser commented Jan 30, 2023 •
edited

It would be nice if the index build progress log message included store timer metrics. At the moment, we can collect the store timer metrics at the end of a build, but it would probably be good to have an it also log metrics as the build is going. The "progress log" messages seem like the logical place to put them, and then users can also use the progress log interval millis to change how much logging happens.
@alecgrieser alecgrieser added the performance Performance issues label Jan 30, 2023
@alecgrieser alecgrieser changed the title Log store timer metrics during progress log message Log store timer metrics during indexer progress log message Jan 30, 2023
@alecgrieser alecgrieser self-assigned this Jan 31, 2023
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Jan 31, 2023
@alecgrieser
Resolve FoundationDB#1984: Log store timer metrics during indexer pro…
e8fd01e 
…gress log message

This adds the store timer metrics to the progress log message that is logged during an index build so that we can have insight into what the performance of a build is while it is going on.

This resolves FoundationDB#1984.
@alecgrieser alecgrieser mentioned this issue Jan 31, 2023
Merged
ScottDugas added a commit that referenced this issue Feb 3, 2023
@ScottDugas
Merge pull request #1988 from alecgrieser/01983-log-metrics-during-pr…
a3bd6fc 
…ogress

Resolve #1984: Log store timer metrics during indexer progress log message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecgrieser alecgrieser

Labels
performance Performance issues
Projects
None yet
Milestone
No milestone
1 participant
@alecgrieser